Skip to content

Global navigation

© 2024 GitHub, Inc.

About Blog Terms Privacy Security Status

Navigate back to

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Create new...
You have no unread notifications

Account menu

funige Funige
Create new...
funige  /   neo  /   Pull requests #109  /  
Open in github.dev Open in a new github.dev tab Open in codespace
Code
Jump to bottom

ブラウザデフォルトのショートカットキー｢ctrl+o｣を無効化。 #109

Merged
merged 1 commit into from Feb 26, 2024
Merged

ブラウザデフォルトのショートカットキー｢ctrl+o｣を無効化。 #109

merged 1 commit into from Feb 26, 2024
+3 −3

Conversation

satopian

Collaborator 

const keys = ["+",";","=","-","s","h","r","y","z","u","o"];
	if ((e.ctrlKey||e.metaKey) && keys.includes(e.key.toLowerCase())){
		e.preventDefault();
	}

NEOの文字入力と、動的パレットのテキストエリアにフォーカスしている時のブラウザデフォルトのショートカットキーのいくつかをキャンセルしています。
そこに、ctrl+oも追加して、ブラウザでファイルを開くショートカットを無効化します。
描画中にctrl+oを使う人はほとんどいないとは思いますが、動作しなくてもいいショートカットキーを無効化して事故を減らします。

@satopian satopian merged commit 0021eb5 into funige:master Feb 26, 2024

Update branch attempt failed

Oops, something went wrong.

@funige

Add a comment

Select a reply

Create a new saved reply
Slash commands
Beta
Give feedback
Slash commands
Beta
Give feedback

An unexpected error has occurred
Markdown is supported
Remember, contributions to this repository should follow our GitHub Community Guidelines.
ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views.
Reviewers
Request up to 15 reviewers
No reviews
Assignees
Assign up to 10 people to this pull request
No one—
Labels
Apply labels to this pull request
None yet
Projects
Projects
None yet
Milestone
Set milestone
No milestone
Development
Link an issue from this repository

Successfully merging this pull request may close these issues.

None yet
Notifications
Customize

Notification settings

Loading...

You’re receiving notifications because you’re watching this repository.

1 participant
@satopian
Lock conversation

Lock conversation on this pull request

  • Other users can’t add new comments to this pull request.
  • You and other collaborators with access to this repository can still leave comments that others can see.
  • You can always unlock this pull request again in the future.

Optionally, choose a reason for locking that others can see. Learn more about when it’s appropriate to lock conversations.

ブラウザデフォルトのショートカットキー｢ctrl+o｣を無効化。 by satopian · Pull Request #109 · funige/neo